Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: cross compile darwin builds #21326

Merged
merged 1 commit into from
Jun 26, 2024
Merged

build: cross compile darwin builds #21326

merged 1 commit into from
Jun 26, 2024

Conversation

DanStough
Copy link
Contributor

Description

For cost reasons, we can cross-compile macos binaries on linux. Historically we didn't do this because of a problem with Go that has since been resolved: #3267.

This step removes the verification of Darwin binaries. I believe this is acceptable since the vast majority of users and on Linux and Windows. Developers will naturally test the Darwin build during the development cycle.

@DanStough DanStough added pr/no-changelog PR does not need a corresponding .changelog entry backport/all Apply backports for all active releases per .release/versions.hcl labels Jun 13, 2024
@DanStough DanStough requested a review from a team as a code owner June 13, 2024 15:49
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Jun 13, 2024
@jm96441n
Copy link
Member

jm96441n commented Jun 13, 2024 •
edited
Loading

quick question: what does the verify step actually do? nvm, read the script and it just checks the version of the binary and all that, I wasn't sure if it did anything related to signing binaries for macos

@DanStough
Copy link
Contributor Author

Yeah, CRT does the binary signing. Sounds like this verify step wouldn't have caught the previous DNS issue anyway since it is only checking the version.

@DanStough DanStough force-pushed the dans/NET-9235/cross-compile-darwin branch from 83df979 to eefed40 Compare June 26, 2024 15:55
@DanStough DanStough enabled auto-merge (squash) June 26, 2024 16:05
@DanStough DanStough merged commit cec66f0 into main Jun 26, 2024
82 checks passed
@DanStough DanStough deleted the dans/NET-9235/cross-compile-darwin branch June 26, 2024 16:13
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Jun 26, 2024
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Jun 26, 2024
Merged
@hc-github-team-consul-core
Copy link
Collaborator

@DanStough, a backport is missing for this PR [21326] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

1 similar comment
@hc-github-team-consul-core
Copy link
Collaborator

@DanStough, a backport is missing for this PR [21326] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

jmurret pushed a commit that referenced this pull request Jul 8, 2024
@DanStough @jmurret
build: cross compile darwin builds (#21326)
1d32803
@dhiaayachi dhiaayachi mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm96441n jm96441n jm96441n approved these changes

Assignees
No one assigned
Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 This release series is longer active on CE, use backport/ent/1.19 pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consul build on OS X doesn't use System Configuration framework for DNS resolution
3 participants
@DanStough @jm96441n @hc-github-team-consul-core